Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TAdev0)

corelib/src/starknet/storage/storage_node.cairo line 14 at r1 (raw file):

//! Storage nodes are particularly valuable when defining structs containing phantom types like
//! `Map` and `Vec`. When a struct is marked with `#[starknet::storage_node]`, it automatically
//! becomes a phantom type, regardless of whether it was explicitly annotated as such.

hmm - it just is marking it as phantom - the "regardless" part seems confusing for me.

Code quote:

//! Storage nodes are particularly valuable when defining structs containing phantom types like
//! `Map` and `Vec`. When a struct is marked with `#[starknet::storage_node]`, it automatically
//! becomes a phantom type, regardless of whether it was explicitly annotated as such.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)

corelib/src/starknet/storage/storage_node.cairo line 14 at r1 (raw file):

removed this part

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TAdev0)

corelib/src/starknet/storage/storage_node.cairo line 20 at r2 (raw file):

//! more appropriate to make them storable using `#[derive(Store)]`. This alternative approach
//! still enables access to individual struct members through `SubPointers` without imposing the
//! phantom type behavior.

you should probably mention the different storage layout for the diffrent cases.

Store:
continuously in the same variable space (up to the size 256 felts)

starknet_node:
Each member is an addition to the key to the location of the storage var.

Code quote:

//! While you can declare any struct as a storage node (even those without phantom types), doing so
//! will make that struct a phantom type. For structs that don't contain phantom types, it's often
//! more appropriate to make them storable using `#[derive(Store)]`. This alternative approach
//! still enables access to individual struct members through `SubPointers` without imposing the
//! phantom type behavior.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)

corelib/src/starknet/storage/storage_node.cairo line 20 at r2 (raw file):

just added storage layout precisions

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TAdev0)